Managing AI-Generated Code Quality

// OVER-ABSTRACTED AI CODE (common smell)
interface DataProcessor<T, R> {
  process(data: T): R;
}

class UserNameProcessor implements DataProcessor<User, string> {
  process(user: User): string {
    return `${user.firstName} ${user.lastName}`;
  }
}

const processor = new UserNameProcessor();
const name = processor.process(user);

// WHAT IT SHOULD BE (simple, direct)
function getUserFullName(user: User): string {
  return `${user.firstName} ${user.lastName}`;
}

const name = getUserFullName(user);

## AI Code Review Checklist

### Correctness
- [ ] Does the code do what was requested? (not more, not less)
- [ ] Are edge cases handled correctly?
- [ ] Are error scenarios handled appropriately?
- [ ] Do the tests test the RIGHT behavior?

### Security
- [ ] No hardcoded secrets or credentials
- [ ] User input is validated and sanitized
- [ ] Auth checks on all protected operations
- [ ] No SQL injection, XSS, or CSRF vulnerabilities

### Consistency
- [ ] Follows existing code patterns in the project
- [ ] Uses the same libraries as the rest of the codebase
- [ ] Naming conventions match the project style
- [ ] File location follows the project structure

### Quality
- [ ] No unnecessary abstractions or over-engineering
- [ ] No verbose/redundant code that could be simplified
- [ ] Comments explain "why" not "what"
- [ ] No phantom features (code that was not requested)

### Performance
- [ ] No N+1 queries or unnecessary database calls
- [ ] No blocking operations in hot paths
- [ ] No memory leaks (unclosed connections, growing arrays)
- [ ] Appropriate use of caching where needed

# Strategies for consistency:

# 1. CLAUDE.md with explicit conventions
# The more specific your CLAUDE.md, the more consistent the output

# 2. Reference existing code
> Follow the exact pattern used in app/components/UserCard.tsx
# This is the most reliable way to get consistent output

# 3. Automated formatting
# Prettier + ESLint catch formatting and style inconsistencies
# Run them automatically on save or pre-commit

# 4. Periodic consistency audits
> Review app/components/ for inconsistencies in:
  - Component structure (export style, prop types location)
  - Error handling patterns
  - State management approaches
  - Import ordering
  Flag any inconsistencies and suggest a unified approach.